[RSDK-6857] support multiple connections #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acmorrow
approved these changes
Mar 8, 2024
micro-rdk/src/common/conn/server.rs
Outdated
| } | ||
| true | ||
| } | ||
| // fn last_error(&mut self) -> Option<ServerError> { |
| @@ -100,7 +100,7 @@ pub async fn serve_web_inner( | |||
| exec.clone(), | |||
| )); | |||
|
|
|||
| let mut srv = ViamServerBuilder::new(mdns, cloned_exec, client_connector, app_config) | |||
| let mut srv = ViamServerBuilder::new(mdns, cloned_exec, client_connector, app_config, 3) | |||
There was a problem hiding this comment.
Below, does it matter that the ESP32 and native serve_web functions have diverged, since the ESP32 one now takes the maximum as a parameter and the native one does not?
There was a problem hiding this comment.
I think its fine as long as we don't have a use case for native beyond testing we don't need to polish it too much
| @@ -100,7 +100,7 @@ pub async fn serve_web_inner( | |||
| exec.clone(), | |||
| )); | |||
|
|
|||
| let mut srv = ViamServerBuilder::new(mdns, cloned_exec, client_connector, app_config) | |||
| let mut srv = ViamServerBuilder::new(mdns, cloned_exec, client_connector, app_config, 3) | |||
There was a problem hiding this comment.
Should native be permitted more than 3? Or do you want to keep it the same with the idea that it should be a fairly faithful reproduction of how an ESP32 micro-rdk behaves?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.